-
Notifications
You must be signed in to change notification settings - Fork 31
Introduce Space, Dimensions, and GeneralDimensions
#360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ytdHuang
commented
Jan 2, 2025
Space, Dimensions, and CompoundDimensionsSpace, Dimensions, and GeneralDimensions
5 tasks
Member
albertomercurio
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aside from these minor comments. Everything is good. However, you kept the previous commits changes of other PRs, here. Could you rebase to only include the changes of this PR?
Member
|
Ok, looking at all the commits changes, everything is fine. |
albertomercurio
approved these changes
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Thank you for contributing to
QuantumToolbox.jl! Please make sure you have finished the following tasks before opening the PR.make test.juliaformatted by running:make format.docs/folder) related to code changes were updated and able to build locally by running:make docs.CHANGELOG.mdshould be updated (regarding to the code changes) and built by running:make changelog.Request for a review after you have completed all the tasks. If you have not finished them all, you can also open a Draft Pull Request to let the others know this on-going work.
Description
Summary of this PR:
New structures:
AbstractSpaceSpaceAbstractDimensionsDimensionsGeneralDimensionsNew field
dimensions(originally calleddims) forQobj/QobjEvo/TimeEvolutionProblem/EigsolveResultNew property
dimsforQobj/QobjEvo/TimeEvolutionProblem/EigsolveResultNew internal functions:
get_dimensions_toget_dimensions_fromdimensions_to_dims: transformAbstractDimensionsto integer-vector_get_dims_string: to get thedimsstring for printingChanged internal functions:
_check_dims->_gen_dimensions. This was the one to check the format of user specifieddims, now it also checks the format and generates theDimensionsstructure.check_dims->check_dimensions. This was the one to check if the twoQobjhave the samedims, now it allows multiple inputQobjand check whether allQobj.dimensionsare equal).Related issues or PRs
close #271
close #353